PEAR Bug Search Results

DB_NestedSet: Feature/Change Request 12981 [Open] new method: updateBranch()

dhscompguy at yahoo dot com — 2008-01-26T11:23:31+00:00

DB_NestedSet Feature/Change Request
Reported by denny
2008-01-26T11:23:31+00:00
PHP: Irrelevant OS: N/A Package Version: 1.4.0RC1

Description:
------------
It would be handy to be able to update fields for an entire branch in one query. For instance --

$nset->updateBranch($branch_rootid, array('is_active' => 0));
$nset->updateBranch($branch_rootid, array('access_flags' => 255));

This class is pretty handy as is though. Thanks much for all your hard work! :)

DB_NestedSet: Bug 12343 [Open] getAllNodes performance suggestion

k dot bizuns at inbox dot lv — 2007-10-25T03:37:25+00:00

DB_NestedSet Bug
Reported by analgiins
2007-10-25T03:37:25+00:00
PHP: Irrelevant OS:  Package Version: 1.4.0RC1

Description:
------------
For example, I have 5 root nodes. To get all tree when _sortMode is NESE_SORT_PREORDER, getAllNodes execute 6 queries - one for getting all root nodes and then in cycle for each root node get sub branch. If we have ordering by NORDER then in lieu of can use only one query, which do sorting, also. 
Just join table to itself (it is needed for get root node for each node in list) and add two fields in order by clause, primary order by node root node NORDER and second order by node LEFT. This one query retrieves all tree with sorting by NORDER.
Here is function from my own NestedSet driver:

function getAllNodes($keepAsArray = false, $aliasFields = true, $addSQL = array())
{
	if ($this->_sortMode == NESE_SORT_PREORDER && $this->secondarySort == $this->flparams['norder'] )
	{
		$nodeSet = array();
		$rootTableAlias = $this->node_table . '_root';
		$systemJoin = sprintf("LEFT JOIN %s AS %s ON %s.%s = %s.%s"
								, $this->_quoteIdentifier($this->node_table), $rootTableAlias
								, $this->node_table, $this->flparams['rootid']
								, $rootTableAlias, $this->flparams['id']
						);
		$addSQL['join'] = !empty($addSQL['join']) ? $systemJoin . ' ' . $addSQL['join'] : $systemJoin ;
		$sql = sprintf('SELECT %s %s
						FROM %s
						%s
						%s
						%s
						ORDER BY %s.%s ASC, %s.%s ASC'
					// Select fields
						, $this->_getSelectFields($aliasFields), $this->_addSQL($addSQL, 'cols')
					// From
						, $this->node_table
					// Joins
						, $this->_addSQL($addSQL, 'join')
					// Where
						, $this->_addSQL($addSQL, 'where', 'WHERE')
					// Group by
						, $this->_addSQL($addSQL, 'append')
					// Order by
						, $rootTableAlias, $this->flparams['norder'], $this->node_table, $this->flparams['l']
					);
		
        if ($this->debug) {
			$this->_debugMessage('getAllNodes() sql: ' . $sql . '
sortMode == ' . $this->_sortMode);
		}
		
		if (!$this->_caching) {
            $nodeSet = $this->_processResultSet($sql, $keepAsArray, $aliasFields);
        } else {
            $nodeSet = $this->cache->call('DB_NestedSet->_processResultSet', $sql, $keepAsArray, $aliasFields);
        }

        if (!$this->_skipCallbacks && isset($this->_hasListeners['nodeLoad'])) {
            // EVENT (nodeLoad)
            foreach (array_keys($nodeSet) as $key) {
                $this->triggerEvent('nodeLoad', $nodeSet[$key]);
            }
        }
        return $nodeSet;
	}
	else {
		$nodeSet = parent::getAllNodes($keepAsArray, $aliasFields, $addSQL);
		return $nodeSet;
	}
}

DB_NestedSet: Bug 12341 [Open] Bug with root nodes

k dot bizuns at inbox dot lv — 2007-10-25T03:06:52+00:00

DB_NestedSet Bug
Reported by analgiins
2007-10-25T03:06:52+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 1.4.0RC1

Description:
------------
Clear table. Create one root node: root_1. For this node left (L) is 1 and right is 2. Everything is ok.
Create second root node: root_2. For this node L is 1 and R is 2 (the same as first). So, again everything is ok.
Now create one sub node under root_1, for example sub_node_1.

For root_1: L = 1, R = 4. Ok.
For sub_node_1: L = 2, R = 3. Ok.
For root_2: L = 1, R = 4. Not ok. root_2 doesn't hold any children so R for the root_2 must be 2.

I fix this bug in this way. In four funciton (createSubNode, createLeftNode, createRightNode, deleteNode) where are generating UPDATE queries wiht sprintf I remove checking for root nodes. In SQL part it's like:
    WHERE %s=%s,

but in sprintf arguments it's like
    $this->flparams['rootid'], $thisnode['rootid'],


In createSubNode - one Update query
In createLeftNode - two Update queries
In createRightNode - one Update query where comment are
    // Update all nodes which have dependent left and right values
And in deleteNode - one Update query where comment are
    // The node isn't a rootnode so close the gap

Kaspars Bizuns

DB_NestedSet: Feature/Change Request 12334 [Open] getChildren doesn't use parameter $forceNorder

k dot bizuns at inbox dot lv — 2009-04-24T11:18:24+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T12:20:44+00:00
PHP: Irrelevant OS:  Package Version: 1.4.0RC1

Description:
------------
Function getChildren doesn't use parameter $forceNorder

DB_NestedSet: Feature/Change Request 12332 [Open] Passing DB_NestedSet object instance in DB_NestedSet_Event

k dot bizuns at inbox dot lv — 2007-10-24T11:52:56+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T11:52:56+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 1.4.0RC1

Description:
------------
In DB_NestedSet_Event method callEvent there is no access to DB_NestedSet object. It can be do just passing an object instance in place where event is executed, see function triggerEvent ( $val->callEvent($event, $node, $eparams); )
Need to change $val->callEvent($this, $event, $node, $eparams);

DB_NestedSet: Feature/Change Request 12330 [Open] new function isLeaf

k dot bizuns at inbox dot lv — 2007-10-24T11:41:33+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T11:41:33+00:00
PHP: 5.2.3 OS:  Package Version: 1.4.0RC1

Description:
------------
It will be greate if there was a function isLeaf

// {{{ isLeaf()
/**
 * Check if node by given id is leaf
 *
 * @access public
 * @param integer $id Id of node to check
 * @return bool True if node is leaf otherwise false
 */
function isLeaf($id)
{
	if ($this->debug){
		$this->_debugMessage('isLeaf($id)');
	}
	
	if (!($node = $this->pickNode($id, true))){
		$epr = array('isLeaf()', $id);
		return $this->_raiseError(NESE_ERROR_NOT_FOUND, PEAR_ERROR_TRIGGER, E_USER_NOTICE, $epr);
	}
	
	return ($node['r'] - $node['l']) == 1;
}
// }}}

DB_NestedSet: Feature/Change Request 12329 [Open] new function hasChildren

k dot bizuns at inbox dot lv — 2007-10-24T11:38:38+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T11:38:38+00:00
PHP: 5.2.3 OS:  Package Version: 1.4.0RC1

Description:
------------
It will be greate if there was a function hasChildren like this:

// {{{ hasChildren()
/**
 * Check if node by given id has children
 *
 * @access public
 * @param integer $id Id of node to check
 * @return bool True if node has children otherwise false
 */
function hasChildren($id)
{
	if ($this->debug){
		$this->_debugMessage('hasChildren($id)');
	}
	
	if (!($node = $this->pickNode($id, true))){
		$epr = array('hasChildren()', $id);
		return $this->_raiseError(NESE_ERROR_NOT_FOUND, PEAR_ERROR_TRIGGER, E_USER_NOTICE, $epr);
	}
	
	return ($node['r'] - $node['l']) > 1;
}
// }}}

DB_NestedSet: Feature/Change Request 12328 [Open] getBreadcrumbs

k dot bizuns at inbox dot lv — 2007-10-24T11:35:17+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T11:35:17+00:00
PHP: 5.2.3 OS:  Package Version: 1.4.0RC1

Description:
------------
It will be greate if there was a function like getBreadcrumbs. Function getParents doesn't return node itself for wat a need to get breadcrumbs.

DB_NestedSet: Feature/Change Request 12327 [Open] New functions

k dot bizuns at inbox dot lv — 2007-10-24T11:31:58+00:00

DB_NestedSet Feature/Change Request
Reported by analgiins
2007-10-24T11:31:58+00:00
PHP: 5.2.3 OS:  Package Version: 1.4.0RC1

Description:
------------
It will be greate if there were functions getFirstSibling, getLastSibling, getPreviuosSibling (alias getPrevNode) and getNextSibling (alias getNextNode)