| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.9.4 |
| Bug #9971 | Improve run-tests diffs of EXPECTF sections | ||
|---|---|---|---|
| Submitted: | 2007-01-29 19:25 UTC | Modified: | 2007-02-14 01:10 UTC |
| From: | yunosh | Assigned: | cellog |
| Status: | Closed | Package: | PEAR (version 1.5.0) |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | 1.5.1 | ||
[2007-01-29 19:25 UTC] yunosh
(Jan Schneider)
Description:
------------
The patch at http://dev.horde.org/~jan/RunTest.php.diff implements a long wanted changed in the test runner. If tests with EXPECTF section failed, the .diff file not only contained the diffing lines, but all lines that have formatting placeholders. This patch fixes that behaviour.
It could probably be activated for EXPECTREGEX sections too, but I didn't have any tests at hand to verify that.
Comments
[2007-01-29 20:11 UTC] cellog
(Greg Beaver)
hi Jan,
Could you fix the mime type of that patch? It's showing as
text/html instead of text/plain. It think adding a .txt
should do it
[2007-01-29 20:15 UTC] yunosh
(Jan Schneider)
Just save it with a right click or wget, the "HTML source" is the correct diff content.
[2007-01-30 07:17 UTC] yunosh
(Jan Schneider)
I updated the patch with an additional check that avoids PHP notices due to not existing array keys.
[2007-02-14 00:00 UTC] cellog
(Greg Beaver)
this seems to me more of a bug than a feature request, changing status
[2007-02-14 01:10 UTC] cellog
(Greg Beaver)
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
had to tweak the patch slightly, but it was otherwise good