Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.4.4

Bug #9586 getUrl has invalid parameter
Submitted: 2006-12-08 12:38 UTC Modified: 2007-02-26 14:16 UTC
From: asnagy Assigned: mj
Status: Closed Package: HTTP_Request (version 1.4.0)
PHP Version: 5.1.6 OS: Linux
Roadmaps: (Not assigned)    
Subscription  


 [2006-12-08 12:38 UTC] asnagy (Andrew Nagy)
Description: ------------ the new getUrl method has 1 parameter: $url This should not be there

Comments

 [2007-02-23 16:37 UTC] mj (Martin Jansen)
The patch below not only fixes this bug, but also patches #9984. Maintainers: I can quickly commit this to CVS and would be happy to do so. Just let me know. Index: Request.php =================================================================== RCS file: /repository/pear/HTTP_Request/Request.php,v retrieving revision 1.51 diff -u -r1.51 Request.php --- Request.php 25 Oct 2006 16:23:31 -0000 1.51 +++ Request.php 23 Feb 2007 21:35:54 -0000 @@ -58,6 +58,13 @@ define('HTTP_REQUEST_HTTP_VER_1_0', '1.0', true); define('HTTP_REQUEST_HTTP_VER_1_1', '1.1', true); +/** + * HTTP_Request main class + * + * @package HTTP_Request + * @author Richard Heyes <richard@phpguru.org> + * @version $Revision$ + */ class HTTP_Request { /** @@ -360,7 +367,7 @@ * @return string Current request URL * @access public */ - function getUrl($url) + function getUrl() { return empty($this->_url)? '': $this->_url->getUrl(); } @@ -1015,6 +1022,10 @@ /** * Response class to complement the Request class +* +* @author Richard Heyes <richard@phpguru.org> +* @package HTTP_Request +* @version $Revision$ */ class HTTP_Response {
 [2007-02-26 14:16 UTC] mj (Martin Jansen)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.