Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.1

Bug #9351 log does not accept the 'limit' switch
Submitted: 2006-11-16 06:31 UTC Modified: 2007-09-17 13:45 UTC
From: kikcho at gmail dot com Assigned: clay
Status: Closed Package: VersionControl_SVN (version 0.3.0alpha1)
PHP Version: Irrelevant OS: Any
Roadmaps: 0.3.1    
Subscription  


 [2006-11-16 06:31 UTC] kikcho at gmail dot com (Kiril Zyapkov)
Description: ------------ The log svn command will not accept a limit argument. Test script: --------------- <? require_once('VersionControl/SVN.php'); $switches = array( 'username' => '', 'password' => '', 'limit' => '1' ); $options = array( 'fetchmode' => VERSIONCONTROL_SVN_FETCHMODE_ASSOC); $svn = VersionControl_SVN::factory('log', $options); $result = $svn->run(array('svn://example.com/repos'), $switches); echo "<pre>"; var_dump($svn->_prepped_cmd); var_dump($result); ?> Here is a patch to fix this behavior: --- Log.php.orig 2006-11-16 11:33:26.000000000 +0000 +++ Log.php.new 2006-11-16 11:33:02.000000000 +0000 @@ -159,7 +159,8 @@ 'non-interactive', 'non_interactive', 'config-dir', - 'config_dir' + 'config_dir', + 'limit' ); @@ -224,6 +225,7 @@ case 'username': case 'password': case 'config-dir': + case 'limit': $_switches .= "--$switch $val "; break; case 'r': Expected result: ---------------- You should only get a single log entry. Actual result: -------------- You see ALL log entries

Comments

 [2006-11-16 06:33 UTC] kikcho at gmail dot com
Sorry about the bad-looking test script, my first post here.
 [2007-09-17 13:45 UTC] clay (Clay Loveless)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.