Report new bug | New search | Development Roadmap Status: Open | Feedback | All

Request #9127 extending make_ticket_links() matched words
Submitted: 2006-10-21 17:14 UTC Modified: 2007-02-24 13:58 UTC
From: quipo Assigned: mj
Status: Closed Package: Web Site
PHP Version: 5.1.0 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2006-10-21 17:14 UTC] quipo (Lorenzo Alberton)
Description: ------------ Attached, a patch to pearweb/include/pear-format-html.php containing a change to the regexp in make_ticket_links() to match these cases: bugfix XXX bug XXX req XXX request XXX At the moment, only these are supported: bug XXX request XXX Test script: --------------- --- /tmp/pear-format-html.1.191.php Sat Oct 21 12:18:11 2006 +++ /CVS_repository/pearweb/include/pear-format-html.php Sat Oct 21 12:18:02 2006 @@ -1142,10 +1142,10 @@ */ function make_ticket_links($text) { - $text = preg_replace('/(?<=php)\s*(bug|request)\s+#?([0-9]+)/i', + $text = preg_replace('/(?<=php)\s*(bug(?:fix)?|req(?:uest)?)\s+#?([0-9]+)/i', ' <a href="http://bugs.php.net/\\2">\\1 \\2</a>', $text); - $text = preg_replace('/(?<![>a-z])(bug|request)\s+#?([0-9]+)/i', + $text = preg_replace('/(?<![>a-z])(bug(?:fix)?|req(?:uest)?)\s+#?([0-9]+)/i', '<a href="/bugs/\\2">\\0</a>', $text); return $text; }

Comments

 [2007-02-24 10:05 UTC] mj (Martin Jansen)
I'll make sure that this gets in.
 [2007-02-24 10:38 UTC] mj (Martin Jansen)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.
 [2007-02-24 13:58 UTC] cellog (Greg Beaver)
testing request 9127, bugfix 9127, bug 9127, req 9127