Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.3.4

Bug #904 PEAR QA: improvement for get_class()-usage
Submitted: 2004-02-26 14:28 UTC
From: pear-qa at lists dot php dot net Assigned:
Status: Wont fix Package: XML_sql2xml
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    

 [2004-02-26 14:28 UTC] pear-qa at lists dot php dot net
Description: ------------ ## from the PEAR QA team ## ## quality-assurance related ## Please note that if you don't react to this issue within 4 weeks the PEAR QA-team will take care of it automatically. This is not "rude" but necessary for QA. If this is a "false positive" and your package is not affected please apologize. This package uses get_class()-calls without care for case-sensitivity of the returned classnames. In PHP 4.x the default for getclass() was that lowercase classnames were returned. However, due to extended DOM functionality, PHP 5.x returns classnames with correct upper-and-lowercase. If you intend to run your package under both PHP4 and PHP5 please consider using case-independent comparisons or apply case-fixes. Found in: FILE: '/cvs/php/pear/XML_sql2xml/sql2xml.php' : /cvs/php/pear/XML_sql2xml/sql2xml.php(268): if (get_class($resultset) == "db_result") { Reproduce code: --------------- Affected are constructs like: if (get_class($foo) == 'foo') { ... } Possible solutions for correct class-checks: strtolower(get_class($foo)) == 'foo' is_a($foo, 'foo') !strcasecmp(get_class($foo), 'foo')


 [2004-04-01 07:25 UTC] chregu
This package won't run on PHP5 anyway, since it heavily relies on the domxml extension, which was completely rewritten for PHP5 A major rewrite for PHP5 is needed.