Description: ------------ The Node::{get|set}Attribute() functions convert the attribute name to lower case before handling it. In XML attribute names are case-sensitive, i.e. <lorem foo="bar"> and <lorem FOO="bar"> are not equivalent. When called on the element <lorem foo="bar">, $node->getAttribute('FOO') currently returns "bar" which is wrong. Instead it should return NULL.

Patch provided by Mika Tuupola: --- Node.php.org 2004-02-06 12:42:38.080016000 +0200 +++ Node.php 2004-02-06 12:42:44.980045000 +0200 @@ -269,8 +269,8 @@ class XML_Tree_Node { */ function getAttribute($name) { - if (isset($this->attributes[strtolower($name)])) { - return $this->attributes[strtolower($name)]; + if (isset($this->attributes[$name])) { + return $this->attributes[$name]; } return null; } @@ -285,7 +285,7 @@ class XML_Tree_Node { */ function setAttribute($name, $value = '') { - $this->attributes[strtolower($name)] = $value; + $this->attributes[$name] = $value; } /** @@ -297,8 +297,8 @@ class XML_Tree_Node { */ function unsetAttribute($name) { - if (isset($this->attributes[strtolower($name)])) { - unset($this->attributes[strtolower($name)]); + if (isset($this->attributes[$name])) { + unset($this->attributes[$name]); } }

Hmm this looks like a BC break. However 2.0 seems to be in beta with no stable release as of yet. Anyways I am not sure why things where done the way they were. But it looks very deliberate. So all in all maybe an option would be more appropriate?

This patch is incorporated in my uber patch, so I'm going to close the bug.