Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.2.0
Bug #8744 manageMB method does not return actual result
Submitted: 2006-09-20 09:08 UTC Modified: 2008-03-23 00:15 UTC
From: rix0r at rix0r dot nl Assigned: richy
Status: Assigned Package: Mail_IMAPv2 (version 0.2.0)
PHP Version: 5.1.4 OS: WinXP
Roadmaps: (Not assigned)    
Subscription  
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes. If this is not your bug, you can add a comment by following this link. If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: rix0r at rix0r dot nl
New email:
PHP Version: Package Version: OS:

 

 [2006-09-20 09:08 UTC] rix0r at rix0r dot nl (Rico)
Description: ------------ A misplacement of the "return $ret;" statement in the manageMB() method causes the function never to return TRUE or FALSE, but always NULL. Attached as test script is a unified diff that fixes this (and another perceived bug in that method), and replaces the "$ret = ...; ....; return $ret;" idiom with something a little more direct, namely a direct "return ...;" Test script: --------------- --- ManageMB.php Wed Sep 20 15:19:27 2006 +++ Kopie van ManageMB.php Wed Sep 20 15:20:37 2006 @@ -91 +91 @@ - $ret = TRUE; + return true; @@ -94 +94 @@ - $ret = FALSE; + return false; @@ -96 +95,0 @@ - break; @@ -102,0 +102 @@ + else @@ -104 +104 @@ - $ret = TRUE; + return true; @@ -107 +107 @@ - $ret = FALSE; + return false; @@ -109 +108,0 @@ - break; @@ -114 +113 @@ - $ret = TRUE; + return true; @@ -117 +116 @@ - $ret = FALSE; + return false; @@ -119 +117,0 @@ - break; @@ -124 +122 @@ - $ret = FALSE; + return false; @@ -126 +123,0 @@ - return $ret;

Comments