Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.2.1
Bug #8744 manageMB method does not return actual result
Submitted: 2006-09-20 14:08 UTC
From: rix0r at rix0r dot nl Assigned: richy
Status: Closed Package: Mail_IMAPv2 (version 0.2.0)
PHP Version: 5.1.4 OS: WinXP
Roadmaps: (Not assigned)    
Subscription  


 [2006-09-20 14:08 UTC] rix0r at rix0r dot nl (Rico)
Description: ------------ A misplacement of the "return $ret;" statement in the manageMB() method causes the function never to return TRUE or FALSE, but always NULL. Attached as test script is a unified diff that fixes this (and another perceived bug in that method), and replaces the "$ret = ...; ....; return $ret;" idiom with something a little more direct, namely a direct "return ...;" Test script: --------------- --- ManageMB.php Wed Sep 20 15:19:27 2006 +++ Kopie van ManageMB.php Wed Sep 20 15:20:37 2006 @@ -91 +91 @@ - $ret = TRUE; + return true; @@ -94 +94 @@ - $ret = FALSE; + return false; @@ -96 +95,0 @@ - break; @@ -102,0 +102 @@ + else @@ -104 +104 @@ - $ret = TRUE; + return true; @@ -107 +107 @@ - $ret = FALSE; + return false; @@ -109 +108,0 @@ - break; @@ -114 +113 @@ - $ret = TRUE; + return true; @@ -117 +116 @@ - $ret = FALSE; + return false; @@ -119 +117,0 @@ - break; @@ -124 +122 @@ - $ret = FALSE; + return false; @@ -126 +123,0 @@ - return $ret;

Comments

 [2011-12-09 15:13 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send
MANUAL CONFIRMATION IS NOT POSSIBLE.  Write a message to pear-dev@lists.php.net
to request the confirmation link.  All bugs/comments/patches associated with this

email address will be deleted within 48 hours if the account request is not confirmed!