Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.1.6

Request #8172 No space between label and sort icon
Submitted: 2006-07-10 04:43 UTC Modified: 2006-12-16 18:39 UTC
From: gbcreation at free dot fr Assigned: olivierg
Status: Closed Package: Structures_DataGrid_Renderer_HTMLTable (version 0.1.0)
PHP Version: 5.1.4 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2006-07-10 04:43 UTC] gbcreation at free dot fr (gontran)
Description: ------------ Line 374, there is a space between the label and the sort icon : $str = "<a href=\"$url\">$label $icon</a>"; When there are many columns, the header of the sorted column wraps, and the sort icon is on a new line under the label. using   in the sortIconASC and sortIconDESC options changes nothing of course :-) I think it's better to let the developer manages this behavior by using normal space or non-breaking space in the sortIconASC and sortIconDESC options. Patch is to remove the space between the $label and $icon variables : $str = "<a href=\"$url\">$label$icon</a>";

Comments

 [2006-07-10 13:07 UTC] wiesemann (Mark Wiesemann)
Removing the space would be a BC (backwards compatibility) break which is heavily discouraged. Okay, the break would be minor but it is possible that people rely on it for their code. Maybe we should add a new option named 'sortIconSeparator' which defaults to ' '? (Olivier?)
 [2006-08-04 16:59 UTC] olivierg at php dot net (Olivier Guilyardi)
I don't like the idea of adding an option for such a tiny detail. I've just removed the space in CVS, as Gontran proposed. It might cause minor layout BC breaks, nothing really important. I agree it's not our job to insert such spaces. This bug is closed. Feel free to reopen it if you disagree with the fix.