Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.5.5

Bug #7650 "Only variables should be assigned by reference" notice
Submitted: 2006-05-17 13:02 UTC
From: pityu-kg at rainstorm dot org Assigned: pfischer
Status: Closed Package: File_Archive (version 1.5.3)
PHP Version: 4.4.2 OS: Windows XP
Roadmaps: (Not assigned)    
Subscription  


 [2006-05-17 13:02 UTC] pityu-kg at rainstorm dot org (KG)
Description: ------------ Notice: Only variable references should be returned by reference in e:\http\egisfoto\pear\File\Archive.php on line 574 And truly, a reference returned. I know its PHP4.4's fault, but it can be workarounded.

Comments

 [2006-12-01 16:34 UTC] demianturner (Demian Turner)
following patch fixes the prob: Index: lib/pear/File/Archive.php =================================================================== --- lib/pear/File/Archive.php (revision 2715) +++ lib/pear/File/Archive.php (working copy) @@ -571,7 +571,8 @@ preg_match($cacheCondition, $source)) { return File_Archive::cache(File_Archive::read($source)); } else { - return File_Archive::read($source); + $obj = File_Archive::read($source); + return $obj; } } else if (is_array($source)) { return File_Archive::readMulti($source); @@ -587,7 +588,7 @@ * * @access private */ - function &_convertToWriter(&$dest) + function _convertToWriter(&$dest) { if (is_string($dest)) { return File_Archive::appender($dest);
 [2007-01-08 19:09 UTC] pfischer at php dot net (Pablo Fischer)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Thanks and sorry for the delay!