Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.3.13

Bug #643 compileDir issue
Submitted: 2004-01-29 13:21 UTC Modified: 2004-01-31 03:01 UTC
From: ahundiak Assigned: alan_k
Status: Closed Package: HTML_Template_Flexy
PHP Version: Irrelevant OS: NA
Roadmaps: (Not assigned)    
Subscription  


 [2004-01-29 13:21 UTC] ahundiak at ingr dot com
Description: ------------ The compile method in Flexy.php has these lines: // on windows the base directory will be C:! // so you have to hard code the path (no relatives on windows if (DIRECTORY_SEPARATOR == "/") { // if the compileDir doesnt start with a / then its under the template dir if ( $this->options['compileDir']{0} != DIRECTORY_SEPARATOR ) { $this->options['compileDir'] = $this->options['templateDir'].'/'.$this->options['compileDir']; } } The templateDir option is an array so the attempt to build a new complieDir path will fail. The comments seem to indicate that this is for Window but the unix path separator is being tested for. Relative paths work fine under unix. I would suggest just removing the above lines of code and requiring the user to provide a valid compileDir.

Comments

 [2004-01-29 19:30 UTC] alan_k
yeap - that bit of code can go.. The wider issue about the engine handles multiple sources and compiles into a single target needs addressing as well. Will try and look at that method this weekend.
 [2004-01-31 03:01 UTC] alan_k
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better. this needs testing now - can you see if it works.