Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 3.2.13

Bug #5920 code analyse
Submitted: 2005-11-10 06:37 UTC Modified: 2006-06-03 06:56 UTC
From: moosh Assigned: avb
Status: Closed Package: HTML_QuickForm
PHP Version: Irrelevant OS: winXP
Roadmaps: (Not assigned)    
Subscription  


 [2005-11-10 06:37 UTC] moosh
Description: ------------ Based on CVS checkout Analyzing ... *(line 286, 288, 290, 293, 296, 299): Variable 'matches' is used before it was assigned. *(line 403): Function 'setDatasource' has both empty return and return with value. (line 440): Function 'setDefaults' has both empty return and return with value. (line 479): Function 'setConstants' has both empty return and return with value. (line 538): Value assigned to variable 'element' is never used *(line 565): include/require with user-accessible variable can be dangerous. Consider using constant instead. *(line 891): Function 'getElementError' has both empty return and return with value. *(line 1058): Function 'addRule' has both empty return and return with value. *(line 1156): Function 'addGroupRule' has both empty return and return with value. *(line 1179): Function 'addFormRule' has both empty return and return with value. *(line 1215): Function 'applyFilter' has both empty return and return with value. *(line 1233): Variable 'v' encountered only once. May be a typo? *(line 1233): Value assigned to variable 'v' is never used *(line 1338): Assignment seen where boolean expression is expected. Did you mean '==' instead of '='? *(line 1470): Variable 'elementName' encountered only once. May be a typo? *(line 1470): Value assigned to variable 'elementName' is never used *(line 1722): Variable 'idx' encountered only once. May be a typo? *(line 1722): Value assigned to variable 'idx' is never used

Comments

 [2005-11-10 08:22 UTC] avb
Bullshit, except for unused variables.
 [2006-06-03 06:56 UTC] avb (Alexey Borzov)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. -- This stuff was fixed, to be precise: *(line 1233): Variable 'v' encountered only once. May be a typo? *(line 1233): Value assigned to variable 'v' is never used *(line 1470): Variable 'elementName' encountered only once. May be a typo? *(line 1470): Value assigned to variable 'elementName' is never used *(line 1722): Variable 'idx' encountered only once. May be a typo? *(line 1722): Value assigned to variable 'idx' is never used