Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.1.4

Bug #5635 Cannot include custom array in a menu entry
Submitted: 2005-10-09 06:52 UTC Modified: 2006-06-01 13:19 UTC
From: o dot persson at gmail dot com Assigned: avb
Status: Closed Package: HTML_Menu
PHP Version: 5.1.0 OS: Debian GNU/Linux
Roadmaps: (Not assigned)    
Subscription  


 [2005-10-09 06:52 UTC] o dot persson at gmail dot com
Description: ------------ I'm including 'parent' for all of my menu entries. This makes me get a PHP error since the array gets converted to an array. It would be nice if HTML_Menu would allow non-string items. Attached is a small patch which accepts arrays. Test script: --------------- Index: ../components/PEAR/HTML/Menu/DirectTreeRenderer.php =================================================================== --- ../components/PEAR/HTML/Menu/DirectTreeRenderer.php (revision 385) +++ ../components/PEAR/HTML/Menu/DirectTreeRenderer.php (working copy) @@ -112,7 +112,7 @@ } $keys = $values = array(); foreach ($node as $k => $v) { - if ('sub' != $k) { + if (!is_array($v)) { $keys[] = '{' . $k . '}'; $values[] = $v; } Actual result: -------------- DirectTreeRenderer.php:120 Array to string conversion.

Comments

 [2006-06-01 13:19 UTC] avb (Alexey Borzov)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. -- Both Direct and DirectTree renderers now check that the values of the custom fields are scalar before trying to use them in str_replace() call.