| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.2.1 |
| Bug #5215 | fetchRow does not return null anymore | ||
|---|---|---|---|
| Submitted: | 2005-08-26 15:24 UTC | Modified: | 2008-03-24 15:56 UTC |
| From: | developer at ckiweb dot com | Assigned: | dufuz |
| Status: | Closed | Package: | DB_ldap |
| PHP Version: | 4.3.9 | OS: | RHEL4 |
| Roadmaps: | (Not assigned) | ||
[2005-08-26 15:24 UTC] developer at ckiweb dot com
Description:
------------
In DB, fetchRow is supposed to return null when there are no more data. In DB_ldap, it is returning false when there is no more data. This is because in some upgrade, the line that checked for false or not was deleted, so the return value is not changed from false to null.
The lines to add are in the fetchRow at line 162. Just add:
if ($row === false) {
$row = null;
}
Test script:
---------------
Just call fetchRow on ldap.
Expected result:
----------------
It should return null when there is no data.
Actual result:
--------------
It returns false.
Comments
[2008-03-24 15:56 UTC] dufuz
(Helgi Þormar Þorbjörnsson)
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
reviewing the commit history, nothing in that function was ever changed but I added the === false return null you suggested since it seems logically right.