Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Bug #5099 Copy ignores source, traget and switches
Submitted: 2005-08-15 09:07 UTC Modified: 2007-09-17 13:40 UTC
From: matthias dot adelhard at hydrometer dot de Assigned: clay
Status: Closed Package: VersionControl_SVN
PHP Version: 5.0.3 OS: Win2000
Roadmaps: 0.3.1    
Subscription  


 [2005-08-15 09:07 UTC] matthias dot adelhard at hydrometer dot de
Description: ------------ Copy.php: 274: $_switches = trim($_switches); 275: $this->_switches = $_switches; 276: 277: $cmd = "$this->svn_path $this->svn_cmd $src $dst $switches"; In line $src, $dst and $switches do not exist in this script. I think instead it should be like this: 276: $src=$args[0]; 277: $dst=$args[1]; 278: $cmd = "$this->svn_path $this->_svn_cmd $src $dst $_switches";

Comments

 [2006-10-06 13:47 UTC] scottmattocks (Scott Mattocks)
Index: SVN/Copy.php =================================================================== --- SVN/Copy.php (revision 1) +++ SVN/Copy.php (revision 2) @@ -274,7 +274,9 @@ $_switches = trim($_switches); $this->_switches = $_switches; - $cmd = "$this->svn_path $this->svn_cmd $src $dst $switches"; + // Fix for bug #5099 && #8343. + $cmd = $this->svn_path . ' ' . $this->svn_cmd . ' '; + $cmd.= $this->_switches . implode(' ', $this->args); $this->_prepped_cmd = $cmd;
 [2007-09-17 13:40 UTC] clay (Clay Loveless)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.