Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.5.6

Request #4610 small addition to fixColDef()
Submitted: 2005-06-16 17:11 UTC
From: wiesemann Assigned:
Status: Closed Package: DB_Table
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: (Not assigned)    
Subscription  
Comments Add Comment Add patch


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 10 - 4 = ?

 
 [2005-06-16 17:11 UTC] wiesemann
Description: ------------ In my DB_Table class I use something like this: array( 'street' => array('label' => 'Street', ...), 'city' => array('label' => 'City', ...), ... ); The difference against how it's done in the documentation is 'label' instead of 'qf_label'. This is because I also use the class to setup tables with Structures_DataGrid (that's now even easier with the new DBTable DataSource *g*) and it does not make much sense to use 'qf_label' for the column header in the tables, and so I use 'label' for the tables and the forms. My feature request is now to change line 744ff. from: if (! isset($col['qf_label'])) { $col['qf_label'] = $elemname . ':'; } to: if (! isset($col['qf_label'])) { if (isset($col['label'])) { $col['qf_label'] = $col['label']; } else { $col['qf_label'] = $elemname . ':'; } } This does not break any script that uses DB_Table but it adds a nice and quick possibility to use DB_Table for (HTML, CSV, XLS, ...) tables via Structures_DataGrid, HTML_Table, ..., and for forms with HTML_QuickForm.

Comments

 [2005-07-24 15:08 UTC] pmjones
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better. Good idea, Mark, I've added it.