Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.1

Bug #4474 Silence htmlspecialchars() calls
Submitted: 2005-05-30 04:16 UTC Modified: 2006-12-16 02:51 UTC
From: yunosh Assigned: pmjones
Status: Closed Package: Text_Wiki
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  


 [2005-05-30 04:16 UTC] yunosh
Description: ------------ htmlspecialchars() (in the Xhtml renderer) can raise warnings if used with an unsupported charset and should be silenced.

Comments

 [2005-05-30 04:17 UTC] yunosh
The same applies to htmlentities() too, of course.
 [2005-05-30 08:24 UTC] pmjones
Jan, would it not be wise to let the errors occur so that users know why the translation isn't working?
 [2005-05-30 08:32 UTC] yunosh
No, because if the specified charset doesn't work, html...() is smart enough to fall back to us-ascii, which is always better than no escaping at all. The end user (who is the one who will see the notice in the end) doesn't know anything to do with message anyway. And the supported charsets change from time to time, so you can't check for the charset before using these functions either.
 [2005-05-30 08:38 UTC] pmjones
This bug has been fixed in CVS. In case this was a documentation problem, the fix will show up at the end of next Sunday (CET) on pear.php.net. In case this was a pear.php.net website problem, the change will show up on the website in short time. Thank you for the report, and for helping us make PEAR better. Good enough for me, Jan; it's fixed in CVS. Thanks. :-)