Description: ------------ compress() does not compress IPv6 address that have '0000' in them. Reproduce code: --------------- require("Net/IPv6.php"); echo Net_IPv6::compress("2010:0588:0000:faef:1428:0000:0000:57ab"); Expected result: ---------------- 2010:0588:0000:faef:1428::57ab Actual result: -------------- 2010:0588:0000:faef:1428:000:000:57ab

Fix: --- Net/IPv6.php Tue Feb 8 16:27:36 2005 +++ ../IPv6.php Tue Feb 8 15:25:56 2005 @@ -116,7 +116,7 @@ $ipp = explode(':',$ip); for($i=0; $i<count($ipp); $i++) { - $ipp[$i] = $ipp[$i]; + $ipp[$i] = dechex(hexdec($ipp[$i])); if(hexdec($ipp[$i])>0) { $ipp[$i]=$ipp[$i].'_'; }

I will check the fix and submit it to CVS during the weekend. Thank you.

Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at http://pear.php.net/get/Net_IPv6

Having trouble, here's some examples: 2001:0760:0202:f265:0001:0002:0003:0025 compresses to 2:01:760:202:f265:1:2:3:25 2001:0618:0400:1c85:0999:0999:0999:0999 doesn't seem to compress at all 3ffe:02e0:0123:0123:0123:0123:0123:0123 compresses to 3ffe:2e::123:123:123:123:123:123 fe80:0000:0250:8dff:0001:0002:0003:0004 compresses to fe8::0:250:8dff:1:2:3:4 Josh

That's a completely different bug. But it's fixed by this almost complete rewrite of Compress(): --- IPv6.php.orig Thu Sep 1 08:54:46 2005 +++ IPv6.php Thu Sep 1 09:52:33 2005 @@ -115,37 +115,22 @@ */ function Compress($ip) { $cip = $ip; - if (!strstr($ip, "::") && strstr($ip, '0:0')) { + if (!strstr($ip, '::')) { $ipp = explode(':',$ip); for($i=0; $i<count($ipp); $i++) { $ipp[$i] = dechex(hexdec($ipp[$i])); - if(hexdec($ipp[$i])>0) { - $ipp[$i]=$ipp[$i].'_'; - } - } - $cip = join(':',$ipp); - $stop = false; - $pattern = "0:0"; - $pos=-1; - - while(!$stop) { - $pos = strpos($cip, $pattern); - if($pos === false) { - $stop = true; - $pos = -1; - } else { - $pattern = $pattern.":0"; - } - } - - - $cip = preg_replace("/".substr($pattern,0,-2)."/", ':', $cip,1); - if(1!=strlen($cip)) { - $cip = str_replace(':::', '::', $cip); - $cip = str_replace('_', '', $cip); - } else { - $cip = "::"; } + $cip = ':' . join(':',$ipp) . ':'; + preg_match_all("/(:0)+/", $cip, $zeros); + if (count($zeros[0])>0) { + $match = ''; + foreach($zeros[0] as $zero) { + if (strlen($zero) > strlen($match)) + $match = $zero; + } + $cip = preg_replace('/' . $match . '/', ':', $cip, 1); + } + $cip = preg_replace('/((^:)|(:$))/', '' ,$cip); } return $cip;

Oops, needs an extra preg_replace() to account for :: at the beginning or the end of the address. --- IPv6.php.orig Thu Sep 1 10:26:08 2005 +++ IPv6.php Thu Sep 1 10:26:15 2005 @@ -131,6 +131,7 @@ $cip = preg_replace('/' . $match . '/', ':', $cip, 1); } $cip = preg_replace('/((^:)|(:$))/', '' ,$cip); + $cip = preg_replace('/((^:)|(:$))/', '::' ,$cip); } return $cip;

Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at http://pear.php.net/get/Net_IPv6

1) testBug14747(NetIPv6Test) Undefined variable: cip /usr/share/php/Net/IPv6.php:438 /usr/share/php/Net/IPv6.php:438 /home/clockwerx/pear/Net_IPv6/tests/NetIPv6Test.php:218

Oops, that was meant for bug #14747