Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.1

Request #19910 preProcessSwitches() never sets 'xml' to false
Submitted: 2013-04-24 18:52 UTC Modified: 2013-04-28 15:20 UTC
From: jorrit Assigned: mrook
Status: Closed Package: VersionControl_SVN (version 0.5.1)
PHP Version: Irrelevant OS: Linux
Roadmaps: 0.5.2    
Subscription  


 [2013-04-24 18:52 UTC] jorrit (Jorrit Schippers)
Description: ------------ When I change the fetch mode after preProcessSwitches() has once run with a fetchmode that triggers setting the xml switch to a value that does not need XML, this change is never recognized because preProcessSwitches() only set 'xml' = true, it never unsets it. I recommend starting the method with: $this->switches['xml'] = false; Test script: --------------- $svn->log->fetchmode = VERSIONCONTROL_SVN_FETCHMODE_XML; $a = $svn->log->run(array($localinfo['url'])); $svn->log->fetchmode = VERSIONCONTROL_SVN_FETCHMODE_RAW; $b = $svn->log->run(array($localinfo['url'])); Expected result: ---------------- $a is xml $b contains raw output Actual result: -------------- $a is xml $b is also xml

Comments

 [2013-04-28 15:20 UTC] mrook (Michiel Rook)
-Status: Open +Status: Closed -Assigned To: +Assigned To: mrook -Roadmap Versions: +Roadmap Versions: 0.5.2
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.