Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Bug #19795 escapeshellarg for switches
Submitted: 2013-01-23 13:54 UTC Modified: 2013-01-23 14:44 UTC
From: ddegasperi Assigned: mrook
Status: Closed Package: VersionControl_SVN (version 0.5.0)
PHP Version: 5.3.3 OS: Centos
Roadmaps: 0.5.1    
Subscription  


 [2013-01-23 13:54 UTC] ddegasperi (Daniel Degasperi)
Description: ------------ In Command.php, function prepare(): $cmdParts[] = $switchPrefix . $switch . ' ' . escapeshellarg($val); instead of $cmdParts[] = $switchPrefix . $switch . ' ' . $val; Test script: --------------- Try with $this->switches = array( 'message' => 'This is a test message' ) Expected result: ---------------- .... --message 'This is a test message' .... Actual result: -------------- .... --message This is a test message ....

Comments

 [2013-01-23 14:00 UTC] mrook (Michiel Rook)
-Status: Open +Status: Feedback
Thank you for taking the time to report a problem with the package. This problem may have been already fixed by a previous change that is in the SVN of the package. Please checking out the SVN repository of this package and upgrade svn checkout svn.php.net/repository/pear/packages/VersionControl_SVN/trunk pear upgrade package2.xml or pear upgrade package.xml If you are able to reproduce the bug with the latest SVN, please change the status back to "Open". Again, thank you for your continued support of PEAR. Arguments are escaped as of https://github.com/pear/VersionControl_SVN/commit/cfbec8bd1963a2e36424764a6672fde6736f5440 Thanks for the report!
 [2013-01-23 14:35 UTC] ddegasperi (Daniel Degasperi)
I saw the patch in #19776, it's the same fix. I consider this ticket as closed.
 [2013-01-23 14:44 UTC] mrook (Michiel Rook)
-Status: Feedback +Status: Closed -Assigned To: +Assigned To: mrook
Thanks!