Description: ------------ Fatal error: Call-time pass-by-reference has been removed in /usr/share/pear/Spreadsheet/Excel/Writer/Worksheet.php on line 2490 Test script: --------------- require_once('Spreadsheet/Excel/Writer.php'); Expected result: ---------------- This should work Actual result: -------------- This gets a fatal error for a call-time pass-by-reference. According to the php documents, the reference should be in the function declaration arguments, rather than in the function call arguments.

Added patch fix-call-time_pass-by-reference.

Very timely patch. Thank you.

After patch I receive Strict standards: Declaration of Spreadsheet_Excel_Writer_Worksheet::_append() should be compatible with Spreadsheet_Excel_Writer_BIFFwriter::_append($data)

The patch works perfectly for me A new release with it would be nice

isn't the patch attached to bug #19359 more adequate ?

Instead of a patch, why not release a new version of this package to the PEAR repo? I can tell you that there are probably a TON of people using this package, and if it suddenly break (we're talking ALL kinds of websites) upon PHP upgrade (which happens automatically in many environments), it will be a disaster. An unnecessary disaster, easily prevented by the Spreadsheet_Excel_Writer pushing out a new release with the patch applied. It's just the right thing to do. Let's get it done and move on.

Added patch fix-call-time_pass-by-reference.

Since there is no still no patch, this is my lightweight composer patch, that works on Unix-like only, due to the "sed" dependency "scripts": { "post-install-cmd" : [ "sed -i '2490s/&$string/$header.$data/' vendor/pear-pear.php.net/Spreadsheet_Excel_Writer/Spreadsheet/Excel/Writer/Worksheet.php" ] }

How to solve this problem? The patch still not ready. How to apply the patch from Laurent Courtin

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Fixed in the master.

This is still broken in PHP 5.6 and due to support for CentOS5 being discontinued, many servers are being upgraded, with the minimum PHP version being 5.6. We are being creative to fix the problem on all our environments, but this will continue to be an increasing problem for lots of people as older versions of PHP get sunsetted.

The issue has been solved on Github, and a new release is available over there (0.9.4). PEAR latest release is 0.9.3, how can we have it updated?

I'll see what I can do but right now you can install the package without composer like so: cd /tmp git clone https://github.com/pear/Spreadsheet_Excel_Writer sudo pear upgrade -f Spreadsheet_Excel_Writer/package.xml

I've pushed a new release. Please see if you could install it. Other than that you may have to install latest development version of pear/OLE.