Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.1.0

Bug #19326 raiseError issue
Submitted: 2012-03-09 15:28 UTC
From: zigo_debian Assigned: doconnor
Status: Closed Package: XML_Parser2
PHP Version: 5.4.0 OS: Debian
Roadmaps: (Not assigned)    
Subscription  


 [2012-03-09 15:28 UTC] zigo_debian (Thomas Goirand)
Description: ------------ When using XML_Parser with PHP 5.4, the following issue appears: PHP Strict Standards: Declaration of XML_Parser::raiseError() should be compatible with & PEAR::raiseError($message = NULL, $code = NULL, $mode = NULL, $options = NULL, $userinfo = NULL, $error_class = NULL, $skipmsg = false) in /usr/share/php/XML/Parser.php on line 703

Comments

 [2012-03-31 02:04 UTC] zigo_debian (Thomas Goirand)
 [2012-03-31 02:08 UTC] zigo_debian (Thomas Goirand)
Hi, Please apply the patch that I have added ASAP. This patch removes one of the constructor which is defined twice, and which isn't acceptable. It also removes the return by reference, and fixes the raiseError() definition which is wrong. PLEASE do not tell again that you want to retain PHP4 compatibility. People willing to use an old version of PHP can also use an old version of your class, that wouldn't be right to leave people following PHP development and keeping conscientiously their server up-to-date that you don't want to help them. I hope this patch will help to have an upstream version fixed ASAP and that this time, it wont take so much time to have such small fixes upstreamed, Cheers, Thomas Goirand (zigo)
 [2012-03-31 02:38 UTC] zigo_debian (Thomas Goirand)
Hi, If you didn't notice, my patch renamed $msg into $message in the function definition, which is obviously wrong. I wont upload another patch, as I guess that you'll be able to manage this. Cheers, Thomas
 [2012-03-31 22:09 UTC] doconnor (Daniel O'Connor)
-Package: XML_Parser +Package: XML_Parser2
 [2012-03-31 22:10 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Closed -Assigned To: +Assigned To: doconnor
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Fixed in git - there's now exceptions, instead of PEAR_Errors.