Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.1.0

Bug #19325 Constructor defined twice
Submitted: 2012-03-09 15:25 UTC
From: zigo_debian Assigned: doconnor
Status: Closed Package: XML_Parser2
PHP Version: 5.4.0 OS: Debian
Roadmaps: (Not assigned)    
Subscription  


 [2012-03-09 15:25 UTC] zigo_debian (Thomas Goirand)
Description: ------------ Hi, The class defines twice the constructor. Once using XML_Parser(), and once using __construct(). With PHP 5.4, this triggers a warning, which is very annoying when parsing XML (this can destroy the output of a document): PHP Strict Standards: Redefining already defined constructor for class XML_Parser in /usr/share/php/XML/Parser.php on line 227 Thanks to remove one of the 2 methods.

Comments

 [2012-03-31 02:03 UTC] zigo_debian (Thomas Goirand)
 [2012-03-31 20:32 UTC] doconnor (Daniel O'Connor)
Thanks for the patch Thomas, but I can't put it on XML_Parser for BC reasons. I'm going to fork and create an XML_Parser2 which lets us sidestep the BC concerns.
 [2012-03-31 21:32 UTC] zigo_debian (Thomas Goirand)
Hi, By "BC", do you mean "backward compatibility"? If so, BC for WHAT? In what way my patches are affecting backward compatibility? Currently, we have quite few reverse dependency: Config File_XSPF Gtk_MDB_Designer Image_JpegMarkerReader Image_JpegXmpReader MDB MDB2 (versions <= 2.0.0beta4) MDB2_Schema Net_Nmap Payment_Process PECL_Gen (versions <= 0.8.5) Services_Yahoo_JP (versions <= 0.1.0) System_ProcWatch Text_Highlighter Tree VersionControl_SVN XML_Beautifier XML_DTD XML_MXML XML_NITF XML_RDDL XML_RSS XML_Serializer XML_Statistics XML_Tree XML_Wddx XML_XUL So, what do you want to do with these packages, that needs a working XML_Parser? Just give-up and let them die, and stop working with PHP 5.4? I really don't get what your logic is. Please do care to explain what is your view here. Thomas
 [2012-03-31 22:09 UTC] doconnor (Daniel O'Connor)
-Package: XML_Parser +Package: XML_Parser2
 [2012-03-31 22:10 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Closed -Assigned To: +Assigned To: doconnor
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.