Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.7.0

Request #18738 Provide public setters for Net_Growl_Application
Submitted: 2011-08-18 00:22 UTC Modified: 2011-09-23 08:31 UTC
From: doconnor Assigned: farell
Status: Closed Package: Net_Growl (version SVN)
PHP Version: Irrelevant OS:
Roadmaps: 2.4.0    
Subscription  


 [2011-08-18 00:22 UTC] doconnor (Daniel O'Connor)
Description: ------------ The constructor does setting behaviour on private variables initially; but there's no way to override these later. What I'm trying to do is refactor Net_Monitor to be more dependency injection friendly - so I want to do is along the lines of: $growl = new Net_Growl(new Net_Growl_Application(null)); $alert = new Net_Monitor_Alert_Growl($growl); ... with information like which server to use being configured later on: $alert->alert($server, $messages, array('user' => ..., 'password' => ...)) { // $this->growl->setPassword($options['password']); } The API does not let me do this easily at the moment

Comments

 [2011-09-22 11:25 UTC] farell (Laurent Laville)
-Status: Open +Status: Assigned -Assigned To: +Assigned To: farell
 [2011-09-22 16:03 UTC] farell (Laurent Laville)
-Status: Assigned +Status: Feedback
Daniel, Let me know if my implementation in PEAR SVN repo match your needs as expected. I expect to publish (if you're agree) in two days Laurent
 [2011-09-22 23:06 UTC] doconnor (Daniel O'Connor)
Thanks; that'll work nicely (provided the self:: vs $this behaviour works just the same)
 [2011-09-23 08:31 UTC] farell (Laurent Laville)
-Status: Feedback +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.