| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.4.0b4 |
| Bug #17820 | REVKEYSIG response is not handled by VerifyStatusHandler | ||
|---|---|---|---|
| Submitted: | 2010-08-26 08:29 UTC | Modified: | 2010-08-31 02:57 UTC |
| From: | alec | Assigned: | gauthierm |
| Status: | Closed | Package: | Crypt_GPG (version SVN) |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2010-08-26 08:29 UTC] alec
(Aleksander Machniak)
Description:
------------
Which makes that empty array is returned from Crypt_GPG verify* methods. Simple fix:
--- VerifyStatusHandler.old 2010-08-26 11:25:53.076780887 +0200
+++ VerifyStatusHandler.php 2010-08-26 11:22:55.244686932 +0200
@@ -105,6 +105,7 @@
case 'GOODSIG':
case 'EXPSIG':
case 'EXPKEYSIG':
+ case 'REVKEYSIG':
case 'REVSIG':
case 'BADSIG':
$signature = new Crypt_GPG_Signature();
Comments
[2010-08-26 11:37 UTC] alec
(Aleksander Machniak)
--- Engine.old 2010-08-26 11:16:31.000000000 +0200
+++ Engine.php 2010-08-26 14:34:34.209119022 +0200
@@ -949,8 +976,10 @@
case 'EXPSIG':
case 'EXPKEYSIG':
+ case 'REVKEYSIG':
case 'REVSIG':
case 'BADSIG':
+ case 'ERRSIG':
$this->_errorCode = Crypt_GPG::ERROR_BAD_SIGNATURE;
break;
[2010-08-26 12:03 UTC] gauthierm
(Michael Gauthier)
REVKEYSIG should definitely be handled here. ERRSIG might have to be handled
separately as it uses a different format.
[2010-08-26 14:31 UTC] gauthierm
(Michael Gauthier)
REVSIG turned out to be a typo and should have been REVKEYSIG. Fixed in revision
302810.
http://svn.php.net/viewvc?view=revision&revision=302810
[2010-08-26 15:17 UTC] alec
(Aleksander Machniak)
Please, fix the same typo in Engine.php file (my second patch).
[2010-08-31 02:57 UTC] gauthierm
(Michael Gauthier)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: gauthierm
This bug has been fixed in SVN.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
Fixed in revision 302908.
http://svn.php.net/viewvc?view=revision&revision=302908