| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.1.3 |
| Request #17532 | Improve coding style | ||
|---|---|---|---|
| Submitted: | 2010-06-29 00:03 UTC | Modified: | 2011-12-10 13:08 UTC |
| From: | doconnor | Assigned: | doconnor |
| Status: | Closed | Package: | Image_Barcode (version SVN) |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2010-06-29 00:03 UTC] doconnor
(Daniel O'Connor)
Description:
------------
There are a number of little coding style annoyances which could be re-visited.
1. Run phpcs
2. Avoid statement like:
if ($error) {
return $imgerror;
} else {
return $img;
}
3. Look at unit tests - there is 0% coverage
4. Consider wrappers around standard functionality to promote testability (imagefontwidth() ImageColorAllocate(), ImageCreate() etc can't be mocked out)
5. Evaluate old PHP4 practices which can be safely abandoned (ie: Bug #17531)
Comments
[2011-12-10 12:49 UTC] doconnor
(Daniel O'Connor)
-Status: Open
+Status: Assigned
Ah thanks for the patch Gemor - but this one is stable. Let's make an
Image_Barcode2 with your patch basically. [2011-12-10 13:05 UTC] doconnor
(Daniel O'Connor)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: doconnor
This bug has been fixed in SVN.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.