Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Bug #17477 Windows directory not quoted in the $arg array of the SVN->run() method
Submitted: 2010-06-09 15:20 UTC Modified: 2010-08-12 17:49 UTC
From: berthold0022 Assigned: mrook
Status: Closed Package: VersionControl_SVN (version 0.3.3)
PHP Version: 5.3.0 OS: Windows XP Pro
Roadmaps: 0.3.4    
Subscription  


 [2010-06-09 15:20 UTC] berthold0022 (St Lungo)
Description: ------------ I'm using phing and its SvnCheckoutTask and SvnUpdateTask to automate build operation, which are using VersionControl_SVN. As I'm working on windows using a path containing spaces, and as the current VersionControl_SVN::run() method doesn't quote the $args array elements when creating the $cmd, the command crashes because it can't resolve the path. For now I'have added a loop at the top of the run method to resolve it: foreach($args as $k=>$v) $args[$k] = escapeshellarg($v); Finally to make the command work, I'd to comment the line 654 of the SVN.php file.

Comments

 [2010-06-09 22:58 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Feedback
Thank you for taking the time to report a problem with the package. This problem may have been already fixed by a previous change that is in the SVN of the package. Please checking out the SVN repository of this package and upgrade svn checkout svn.php.net/repository/pear/packages/VersionControl_SVN/trunk pear upgrade package2.xml or pear upgrade package.xml If you are able to reproduce the bug with the latest SVN, please change the status back to "Open". Again, thank you for your continued support of PEAR. This was probably fixed by Bug #16892 svn checkout http://svn.php.net/repository/pear/packages/VersionControl_SVN/trunk/ pear upgrade -f package.xml ... and see if that fixes it
 [2010-06-11 11:12 UTC] berthold0022 (St Lungo)
Thanks, I've got the last trunk version but it doesn't solve my second problem about spaces in the destination directory (in which to perform the checkout). I still have to appy escapeshellarg on this destination directory. But is it on you side to correct the problem, or on the phing svn task extension side?
 [2010-08-12 17:40 UTC] mrook (Michiel Rook)
-Status: Feedback +Status: Assigned -Assigned To: +Assigned To: mrook -Roadmap Versions: +Roadmap Versions: 0.3.4
 [2010-08-12 17:49 UTC] mrook (Michiel Rook)
-Status: Assigned +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.