| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.2.3 |
| Bug #17437 | Deprecated: Assigning the return value of new by reference | ||
|---|---|---|---|
| Submitted: | 2010-05-26 02:05 UTC | ||
| From: | caribou | Assigned: | justinpatrin |
| Status: | Bogus | Package: | Text_Wiki (version SVN) |
| PHP Version: | 5.3.0 | OS: | Irrelevant |
| Roadmaps: | (Not assigned) | ||
[2010-05-26 02:05 UTC] caribou
(Pascal Corpet)
Description:
------------
Using Text_Wiki with PHP 5.3.0 will raise many warnings :
Deprecated: Assigning the return value of new by reference is deprecated
Comments
[2010-06-03 05:12 UTC] doconnor
(Daniel O'Connor)
-Status: Assigned
+Status: Feedback
Pascal, got any specific line numbers? [2010-06-04 02:10 UTC] caribou
(Pascal Corpet)
@doconnor: search for "=& new" in Wiki.php
lines: 477, 1328, 1364, 1397
[2010-06-04 22:07 UTC] justinpatrin
(Justin Patrin)
-Status: Feedback
+Status: Bogus
Unfortunately, unless I've missed a change in the rules, we can't make this change since it would break BC with PHP4, which this package was targeted at. [2010-06-04 23:19 UTC] caribou
(Pascal Corpet)
@justinpatrin: I totally agree and find it quite annoying that there is no way to make it work in both PHP4 and PHP5.3 without any warning.
There are few things that could be done:
- create a new branch that breaks PHP4 compatibility
- advertize that this package is not fully compatible with PHP5.3 and later so that projects that want to be don't use it or accept to turn off warnings
- explore more precisely the code to see what would be lost by taking of the & (in most case it is a matter of copy time and memory allocation for nothing but the code still works)
[2011-04-14 13:25 UTC] bretrzaun
(Bret R. Zaun)
Why not simply drop PHP4 compatibility as every else is doing / suggesting ?