Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Bug #17268 Windows "Fix" actually prevents execution
Submitted: 2010-03-25 19:56 UTC Modified: 2010-08-12 17:49 UTC
From: finewolf Assigned: mrook
Status: Closed Package: VersionControl_SVN (version 0.3.3)
PHP Version: Irrelevant OS: Windows
Roadmaps: 0.3.4    
Subscription  


 [2010-03-25 19:56 UTC] finewolf (Andrew Moore)
Description: ------------ A simple command executed in Windows is broken by the "fix" included in the SVN.php at line 654 is actually preventing VersionControl_SVN from correctly executing the wanted command. Expected result: ---------------- No errors generated. Actual result: -------------- "svn log --username REMOVED --password REMOVED --no-auth-cache --verbose --non-interactive --xml "C:' is not recognized as an internal or external command, (cmd: "svn log --username REMOVED --password REMOVED --no-auth-cache --verbose --non-interactive --xml "C:/Complex Path/Local Copy/"")

Comments

 [2010-08-11 10:59 UTC] kolky (Alexander van der Kolk)
The issues is that it puts the quotation marks around the whole command instead of only around the executable path. Ie: "C:\Program Files\Subversion\bin\svn.exe log http://localhost/repos/test" should be: "C:\Program Files\Subversion\bin\svn.exe" log http://localhost/repos/test
 [2010-08-11 11:38 UTC] kolky (Alexander van der Kolk)
I made a temporary fix for myself, replace: $cmd = '"' . $cmd . '"'; with: $cmd = str_replace( $this->svn_path, '"'.$this->svn_path.'"', $cmd );
 [2010-08-12 17:40 UTC] mrook (Michiel Rook)
-Status: Open +Status: Assigned -Assigned To: +Assigned To: mrook -Roadmap Versions: +Roadmap Versions: 0.3.4
 [2010-08-12 17:49 UTC] mrook (Michiel Rook)
-Status: Assigned +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.