Description: ------------ Mirroring the recent changes to Net_SMTP, a patch to allow body text to be passed as a resource to send().

Added patch bodytext-as-resource.patch.

Since this just reads the entire file resource into memory, how is it better than simply putting a file_get_contents / otherwise doing what the patch is doing outside of the class?

Because, without this patch, it is impossible to pass a resource to Net_SMTP. For example, say I have a 10 MB mail message. In Horde, this message is kept in various temporary resources, rather than text, to conserve memory. When it comes time to pass to send(), it is much preferable to send in a resource rather than converting to a string. Not only do you need to convert to a string, IIRC either Mail or Net_SMTP may alter this string resulting in the need for over 20MB+ to be allocated. Additionally, the sendmail driver is also made more efficient. With the new code, with the above example, there should not need to be any additional memory allocated when sending. With the old code, the user not only has to manually covert the resource himself, but will take an additional 10 MB+ hit when converting to a string. This patch only coverts to a memory string for the drivers that don't support resources - nanmely the built-in mail() PHP function. In this case, we are not losing anything since we would need to do this anyway.

For the record, we implemented these enhancements in the Horde_Mail library. Passing around data in a stream vastly reduces PHP memory usage - the Mail package is pretty much unusable for large messages if you have a somewhat conservative PHP memory_limit set (e.g. 32 MB).

No use keeping this open. We long since ditched Mail and moved to our Horde_Mail fork due to performance and security concerns.

This is probably the more correct status.