Description: ------------ Deprecated: Assigning the return value of new by reference is deprecated on line 616 Deprecated: Function eregi() is deprecated in on line 420

eregi can be fixed, new-by-ref not - because we need to keep backward compatibility to php4.

Hasn't php4 reached its EOL? Why do people still bother writing code for it? Is it not possible to create a new version of XML Parser that requires PHP 5.0+?

http://www.phpdeveloper.org/news/8235 http://us3.php.net/archive/2007.php PHP 4 has been done for almost 3 years (July 13th, 2007) I would love to see an updated version of XML_Parser so I can get rid of these deprecation warnings that have been filling my logs. Please consider this. Is XML_Parser still under development? It seems surprising that these deprecation warnings aren't mentioned more frequently in a google search...

COME ON! You can't say "because of php 4, I can't make it compatible with php 5.3". That's a non-sense. If you really wish to continue to be compatible with php 4 (which I think is useless pain), then make a test on the version of php you are running. Something like this will do: $regexp = "^testit\$"; if (version_compare( phpversion(), '5.3.0') >= 0){ $check_result = prereg_match( "/" . $regexp . "/i" , $myvar); }else{ $check_result = eregi( $regexp , $myvar); } I'll send a patch file to you if I have time, but really, it's not hard to do. Thomas

@zigo : this is not possible because PHP will parse the wrongful code anyhow and issue the warning (even if it will never be actually run)

That's absolutely wrong. A function that is not called will NOT generate a warning before it's called. Why? Because you can create function dynamically, so it would be wrong to display a warning. So your argument doesn't work, and you can still change your code to use preg_match instead of ereg. Anyway, using ereg in PHP6 is not only deprecated and display a notice: it will crash as the function has been removed. So, even if what you pretend was right (it is not), then what would you prefer ? Be totally incompatible with the new version, simply because you don't want a warning in the antediluvian version? It doesn't make sense at all. Please correct the current version of XML_Parser so that we don't have to carry-on distribution specific patches (Debian, in my case), which are a pain to maintain and that will be different in each distribution.

@zigo: I just tried the following. file test2.php: if (false) $a =& new A(); file test.php: error_reporting(E_ALL); require_once 'test2.php'; I get a warning for deprecated return value of new. In this case the warning is not for the function but for the use of "=& new". So the patch I submit won't work. :-( If you find a way, please tell me.

That might be correct for returning a value as reference. However, testing against the PHP version for choosing eregi preg_match WILL work. I will involve the Debian pkg-php-pear team if you like, so that they can find a solution for the returning a reference issue.

Correcting the erig is easy: preg_match function works in both PHP4 and PHP 5.3. The patch I sumbitted earlier takes care of this warning.

@zigo, I didn't notice you wrote "if you like" in your comment. I would very much enjoy a way of fixing this issue on debian; so if you can contact them, please do.

FYI: I tried to get the pkg-php team involved, but it didn't work, as you can see.

A patch has been sent to this bug tracker quite a long time ago. Why isn't it applied to the package? Please fix this issue. Thomas

I just saw that a new version has come out (1.3.4), but it looks like this problem is still present.

Just a heads up, the eregi usage has already been discontinued in this package, in 1.3.3: http://svn.php.net/viewvc/pear/packages/XML_Parser/trunk/Parser.php? r1=266395&r2=302733 Was done as a part of a fix for Bug #17725

And has the return value been fixed as well? I did fix it in my Debian package too, so I wont upgrade the SID package to the latest version of XML_Parser until the return as reference is fixed too. Thomas

Can't the same thing be done in PHP 4 without the return by reference? I'm not sure I see why it is done by reference in the first place. Unfortunately, I don't have PHP 4 to test this out with.

Hi, Is there any update with this bug? I'm still carrying a patch in Debian to remove the return as reference, and it's been now quite a long time this bug entry has been opened. Please consider fixing ! I'm adding a new patch that has only the return as reference fix, since the ereg calls have been replaced by preg in the latest release. Cheers, Thomas Goirand (zigo)

Added patch removes-return-as-reference.

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.