Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.14.4

Request #16124 Add EOL option support for error_log
Submitted: 2009-04-19 22:47 UTC
From: farell Assigned: jon
Status: Wont fix Package: Log (version 1.11.4)
PHP Version: 5.2.9 OS:
Roadmaps: (Not assigned)    
Subscription  


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 23 + 27 = ?

 
 [2009-04-19 22:47 UTC] farell (Laurent Laville)
Description: ------------ While I played with lot of Log handlers, I've noticed that "error_log" driver did not support yet the end-of-line configure option, as "file" did it. I propose a patch to error_log.php r 1.9 to add EOL option support in same way as file driver implemented it. BTW, I read on your user-doc http://www.indelible.org/php/Log/guide.html#the-file-handler you wrote "The end-on-line character sequence." Is it a typo error ? For me EOL means for "end-of-line" !

Comments

 [2009-04-19 22:48 UTC] farell (Laurent Laville)
The following patch has been added/updated: Patch Name: error_log_1_9.patch Revision: 1240163294 URL: http://pear.php.net/bugs/patch-display.php?bug=16124&patch=error_log_1_9.patch&revision=1240163294&display=1
 [2009-05-25 03:06 UTC] jon (Jon Parise)
-Status: Open +Status: Analyzed -Assigned To: +Assigned To: jon
I'm not sure this is a good idea (although that doesn't mean it's a bad idea). I intentionally left out the "end-of-line" stuff from the error_log handler because I didn't think that level of formatting was appropriate for string passed to error_log(). If the ultimate output from error_log() needs to be lines of text, then the code which actually writes error entries should be adding the newlines. But that would be up to the way that error_log() itself is configured, and I don't think the Log package should make assumptions about that.
 [2009-05-28 07:38 UTC] jon (Jon Parise)
-Status: Analyzed +Status: Wont fix