| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.32.0 |
| Bug #15875 | Bug diff vs bug comments problem | ||
|---|---|---|---|
| Submitted: | 2009-02-03 20:14 UTC | ||
| From: | doconnor | Assigned: | doconnor |
| Status: | Closed | Package: | pearweb |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2009-02-03 20:14 UTC] doconnor
(Daniel O'Connor)
Description:
------------
Regression: If you change a bug's status and provide a comment, the text diff (which is awesome) clobbers the comment.
Test script:
---------------
Expected result:
----------------
Actual result:
--------------
Comments
[2009-02-03 19:53 UTC] doconnor
(Daniel O'Connor)
Alright, testing showed that strrpos() did surprising things.
I've committed a fix in CVS for this.
[2009-02-03 19:53 UTC] doconnor
(Daniel O'Connor)
-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: doconnor
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better. [2009-02-03 20:36 UTC] doconnor
(Daniel O'Connor)
This looks suspicious:
output_note()
// This has to be done so we don't wordwrap the changeset part again
$needle = strrpos($comment, 'div>');
$fix = substr($comment, $needle, strlen($comment));
$status = substr($comment, 0, $needle);
$comment = htmlspecialchars(wordwrap($fix, 72, "\n", true), ENT_QUOTES, 'ISO-8859-15', false);
$comment = $status . $comment;
$comment = make_ticket_links(addlinks($comment));
echo $comment;
basically, the generate changeset and comment code parts are fine, but the above code isn't immediately clear to me