Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.21.8

Bug #15676 Date_Holidays_EnglandWalse
Submitted: 2009-01-19 08:48 UTC Modified: 2009-01-19 16:56 UTC
From: terrycurran999 Assigned: kguest
Status: Closed Package: Date_Holidays (version 0.20.1)
PHP Version: Irrelevant OS: Any
Roadmaps: 0.21.0    
Subscription  


 [2009-01-19 08:48 UTC] terrycurran999 (Terry Curran)
Description: ------------ The calculations of first Monday in Month in Date_Holidays_EnglandWales is dependant on the calculation nthMondayInMonth, in Date_Holidays_USA, this dependency should be removed (or documented). I would have expected the calculation of nthMondayInMonth to be in the main Date_Holidays code, or the even be a more generic format of nthWeekdayInMonth!

Comments

 [2009-01-19 15:59 UTC] kguest (Ken Guest)
auditing all drivers for this refactoring
 [2009-01-19 16:56 UTC] kguest (Ken Guest)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. The following are affected by this bug fix and yes, I have an imaginatively named laptop: kguest@kguest-laptop:~/pear/Date_Holidays/Holidays$ cvs commit -m"refactoring work initiated by Bug #15676" cvs commit: Examining . cvs commit: Examining Driver cvs commit: Examining Filter cvs commit: Examining Filter/Germany cvs commit: Examining Filter/Iceland cvs commit: Examining Filter/Ireland cvs commit: Examining Filter/Netherlands ? Driver/Switzerland.php COMMITINFO /repository/pear/Date_Holidays/Holidays Driver.php COMMITINFO /repository/pear/Date_Holidays/Holidays/Driver Brazil.php Iceland.php Japan.php Romania.php USA.php Ukraine.php Checking in Driver.php; /repository/pear/Date_Holidays/Holidays/Driver.php,v <-- Driver.php new revision: 1.32; previous revision: 1.31 done 99991 LOGINFO pear-cvs@lists.php.net kguest pear/Date_Holidays/Holidays Driver.php,1.31,1.32 99991 bailing Checking in Driver/Brazil.php; /repository/pear/Date_Holidays/Holidays/Driver/Brazil.php,v <-- Brazil.php new revision: 1.4; previous revision: 1.3 done Checking in Driver/Iceland.php; /repository/pear/Date_Holidays/Holidays/Driver/Iceland.php,v <-- Iceland.php new revision: 1.9; previous revision: 1.8 done Checking in Driver/Japan.php; /repository/pear/Date_Holidays/Holidays/Driver/Japan.php,v <-- Japan.php new revision: 1.5; previous revision: 1.4 done Checking in Driver/Romania.php; /repository/pear/Date_Holidays/Holidays/Driver/Romania.php,v <-- Romania.php new revision: 1.6; previous revision: 1.5 done Checking in Driver/USA.php; /repository/pear/Date_Holidays/Holidays/Driver/USA.php,v <-- USA.php new revision: 1.12; previous revision: 1.11 done Checking in Driver/Ukraine.php; /repository/pear/Date_Holidays/Holidays/Driver/Ukraine.php,v <-- Ukraine.php new revision: 1.6; previous revision: 1.5 done 99993 LOGINFO pear-cvs@lists.php.net kguest pear/Date_Holidays/Holidays/Driver Brazil.php,1.3,1.4 Iceland.php,1.8,1.9 Japan.php,1.4,1.5 Romania.php,1.5,1.6 USA.php,1.11,1.12 Ukraine.php,1.5,1.6 99994 Mailing the commit email to pear-cvs@lists.php.net kguest@kguest-laptop:~/pear/Date_Holidays/Holidays$