Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.2.1

Request #15368 Support RFC 3986 with respect to urlencoding
Submitted: 2008-12-20 21:57 UTC Modified: 2009-01-23 13:05 UTC
From: gauthierm Assigned: avb
Status: Closed Package: HTTP_Request2 (version 0.1.0)
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: 0.3.0    
Subscription  


 [2008-12-20 21:57 UTC] gauthierm (Michael Gauthier)
Description: ------------ PHP 5.3's rawurlencode() will use RFC 3986, but previous versions use RFC 1738. See http://pear.php.net/bugs/bug.php?id=15367

Comments

 [2008-12-28 08:27 UTC] avb (Alexey Borzov)
Can you please be a bit more verbose on what RFC 3986 is, why HTTP_Request2 should implement that and why do you mention rawurlencode() here. JFYI: there are *no* [raw]urlencode() calls in HTTP_Request2 package.
 [2008-12-28 13:05 UTC] gauthierm (Michael Gauthier)
RFC 3986 is a more recent RFC for the syntax of URIs. With respect to urlencoding, the main difference is that the tilde is no longer a reserved character and is no longer encoded. HTTP_Request2 is using http_build_query() which uses the same encoding as rawurlencode(). Amazon's Web Services says URL-encoding should conform to RFC 3986 rather than RFC 1738. I haven't come across any cases where it fails yet, so this feature request s not high-priority. It's also possible that this feature would be better implemented in Net_URL2, and then used instead of http_build_query() in HTTP_Request2.
 [2009-01-16 16:06 UTC] avb (Alexey Borzov)
OK, if it's the matter of decoding '~' after http_build_query(), I'll make this change.
 [2009-01-16 19:58 UTC] gauthierm (Michael Gauthier)
I think Christian committed a static urlencode method to Net_URL2 CVS that does this. http://cvs.php.net/viewvc.cgi/pear/Net_URL2/URL2.php?r1=1.17&r2=1.18
 [2009-01-23 13:05 UTC] avb (Alexey Borzov)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.