Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.3.12

Bug #14893 Unit tests fail - expected results need updating
Submitted: 2008-10-27 01:39 UTC Modified: 2008-10-28 10:13 UTC
From: doconnor Assigned: doconnor
Status: Closed Package: HTML_Template_Flexy (version CVS)
PHP Version: 5.2.4 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2008-10-27 01:39 UTC] doconnor (Daniel O'Connor)
Description: ------------ I suspect someone went to town with PHPCS, and now the expected results are out. Test script: --------------- pear run-tests Expected result: ---------------- Tests pass Actual result: -------------- 61) /home/clockwerx/pear/HTML_Template_Flexy/tests/test_looping.html.phpt --- Expected +++ Actual @@ -16,7 +16,7 @@ Bug #84 <?php if ($this->options['strict'] || (is_array($t->list) || is_object($t->list))) foreach($t->list as $i) {?> - <?php if ($this->options['strict'] || (isset($t) && method_exists($t,'method'))) echo htmlspecialchars($t->method($i));?> + <?php if ($this->options['strict'] || (isset($t) && method_exists($t, 'method'))) echo htmlspecialchars($t->method($i));?> <?php }?> <?php if ($this->options['strict'] || (is_array($t->list) || is_object($t->list))) foreach($t->list as $i => $j) {?> @@ -25,7 +25,7 @@ <table> <?php if ($this->options['strict'] || (is_array($t->xyz) || is_object($t->xyz))) foreach($t->xyz as $abcd => $def) {?><tr> - <td><?php echo htmlspecialchars($abcd);?>, <?php if ($this->options['strict'] || (isset($t) && method_exists($t,'test'))) echo htmlspecialchars($t->test($def));?></td> + <td><?php echo htmlspecialchars($abcd);?>, <?php if ($this->options['strict'] || (isset($t) && method_exists($t, 'test'))) echo htmlspecialchars($t->test($def));?></td> </tr><?php }?> </table>

Comments

 [2008-10-27 02:31 UTC] doconnor (Daniel O'Connor)
Patch at: http://pastebin.com/f40160208 Still has: 4 FAILED TESTS: /home/clockwerx/pear/HTML_Template_Flexy/tests/test_bug_2959.html.phpt /home/clockwerx/pear/HTML_Template_Flexy/tests/test_flexy_raw_with_element.html.phpt /home/clockwerx/pear/HTML_Template_Flexy/tests/test_include_block.html.phpt /home/clockwerx/pear/HTML_Template_Flexy/tests/test_includes.html.phpt (other bugs raised for the first two, no idea about the second two)
 [2008-10-28 10:13 UTC] doconnor (Daniel O'Connor)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.