Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.3.3

Request #14763 Patch for URI_Template::getTemplateVariables() + CS
Submitted: 2008-10-08 14:50 UTC Modified: 2008-11-30 09:11 UTC
From: izi Assigned: mj
Status: Closed Package: URI_Template (version CVS)
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  


 [2008-10-08 14:50 UTC] izi (David Jean Louis)
Description: ------------ Hi Martin, First, kudos for this package it works really great. I'm using it for a REST client/server library and I needed a method to retrieve an array of the vars defined in the uri template, the attached patch adds this functionality and the relevant unit test. This patch also fix some cosmetic coding standard issues, changes the "private" members to protected in order to make the class more subclassing friendly, and also adds type hinting to methods. If you want, feel free to add me as developer for the package and I'll integrate the changes myself if you think that it's ok. Cheers, David

Comments

 [2008-10-10 02:24 UTC] mj (Martin Jansen)
I committed the part of the patch that implements getTemplateVariables() and rolled release 0.3.0 of URI_Templates. I'm unsure how much of your CS fixes I want to roll into the code base though. Hopefully I'll be able to figure this out on the weekend. Thanks for your patch!
 [2008-11-30 09:11 UTC] mj (Martin Jansen)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.