Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.1

Bug #14625 Autodetect mode in string.php contains incorrect logic
Submitted: 2008-09-09 14:55 UTC Modified: 2008-09-10 03:58 UTC
From: stim Assigned: yunosh
Status: Closed Package: Text_Diff (version 1.0.0)
PHP Version: Irrelevant OS:
Roadmaps: (Not assigned)    
Subscription  


 [2008-09-09 14:55 UTC] stim (Stim Stim)
Description: ------------ Line 51 to 52 of string.php read: } elseif ($context === false || $context === false) { $mode = $context !== false ? 'context' : 'unified'; } else { This makes no sense and probably should read: } elseif ($context === false || $unified === false) { $mode = $context !== false ? 'context' : 'unified'; } else { for otherwise line 52 will always evaluate to 'unified'. (even though this bug will probably never raise an error in the state)

Comments

 [2008-09-10 03:58 UTC] yunosh (Jan Schneider)
Thank you for your bug report. This issue has been fixed in the latest released version of the package, which you can download at http://pear.php.net/get/Text_Diff