Description: ------------ If you are using addNode($node) passing two or more times the same variable "overwrites" previously added nodes. This behaviour is not intuitive and erroneous when using addNode in loops constructs (see example) or recursions. Test script: --------------- $graph = new Structures_Graph(); for ($i=0; $i<=1; $i++) { $node = new Structures_Graph_Node(); $node->setData($i); $graph->addNode($node); } $nodesInGraph = $graph->getNodes(); foreach ($nodesInGraph as $nodeInGraph) { echo $nodeInGraph->getData().'<br/>'; } Expected result: ---------------- 0 1 Actual result: -------------- 1 1

@janjonas This is not a bug. You should assign the variables by reference. Like so: Test script: --------------- $graph =& new Structures_Graph(); for ($i=0; $i<=1; $i++) { $node =& new Structures_Graph_Node(); $node->setData($i); $graph->addNode($node); } $nodesInGraph = $graph->getNodes(); foreach ($nodesInGraph as $nodeInGraph) { echo $nodeInGraph->getData().'<br/>'; } Expected result: ---------------- 0 1 Actual result: -------------- 0 1

As much as it pains me to say it, clone or reference stuff is the way to go here. "Fixing" it would break it for PHP 4 users, and get me shot.