Description: ------------ good be to select trainling characters to append in writeLine. Default is \r\n which is not in every case good.

i made patch. is acceptable ? --- Socket.php 2008-05-03 21:58:10.000000000 +0200 +++ Socket_new.php 2008-06-19 22:05:34.000000000 +0200 @@ -78,6 +78,8 @@ */ var $lineLength = 2048; + var $trailing = "\r\n"; + /** * Connect to the specified port. If called when the socket is * already connected, it disconnects and connects again. @@ -165,6 +167,15 @@ return true; } + function getTrailing() { + return $this->trailing; + } + + function setTrailing($trailing) { + $this->trailing = $trailing; + return true; + } + /** * Find out if the socket is in blocking mode. * @@ -333,7 +344,7 @@ } /** - * Write a line of data to the socket, followed by a trailing "\r\n". + * Write a line of data to the socket, followed by a trailing $this->trailing. * * @access public * @return mixed fputs result, or an error @@ -344,7 +355,7 @@ return $this->raiseError('not connected'); } - return fwrite($this->fp, $data . "\r\n"); + return fwrite($this->fp, $data . $this->trailing); } /** @@ -469,7 +480,7 @@ while (!feof($this->fp) && (!$this->timeout || time() < $timeout)) { $line .= @fgets($this->fp, $this->lineLength); if (substr($line, -1) == "\n") { - return rtrim($line, "\r\n"); + return rtrim($line, $this->trailing); } } return $line; trailing characters are selectable by setTrailing (default is \r\n)

New features should go into a new package. Net_Socket is purely in maintenance mode.

This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. I was closing other bugs so I changed my mind, cleaned up the patch, and committed it. Please look at coding standards next time, and use the upload feature for patches so the lines don't get butchered.