Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.4

Bug #1388 www links not expanded correctly
Submitted: 2004-05-11 21:13 UTC Modified: 2005-10-18 08:11 UTC
From: shaun at aegisdesign dot co dot uk Assigned: quipo
Status: Closed Package: HTML_BBCodeParser
PHP Version: 4.3.3 OS: Linux
Roadmaps: (Not assigned)    
Subscription  


 [2004-05-11 21:13 UTC] shaun at aegisdesign dot co dot uk
Description: ------------ If you have have Links enabled, BBCodeParser tries to expand www.domain.com It doesn't however add the http:// in the href attribute so you end up with <a href='www.domain.com'>www.domain.com</a> which gets treated as a relative link.

Comments

 [2005-09-26 21:20 UTC] seth at pricepages dot org
I've created a new version of the filter Links.php that fixes Bugs #1388, #1512, #1755, and #3932. It also adds a few extra things, such as a list of accepted schemes, adding a trailing slash to the url where appropriate, and removing trailing whitespace from the file. Please bang on it and tell me what you think and send me a testcase/patch if something breaks. Like everyone here, I'd like this to be bulletproof. Maybe once the maintainer comes out of hibernation we can get this into the main tree. One thing that could be fixed is matching anything not "[url]" or "[url=" brackets in the first preparse regexp. I'm not sure the best regular expression there. Here is a link to the updated class: http://pricepages.org/bbcode/Link.php.zip
 [2005-09-26 21:39 UTC] shaun at aegisdesign dot co dot uk
Thanks Seth. That fix solves the URL issue I raised in this bug report. I'll give it a fuller workout later to see how it mixes with some other uses. The link you gave had a typo btw - should be... http://pricepages.org/bbcode/Links.php.zip
 [2005-10-18 08:11 UTC] quipo
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.