Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.26.0

Request #13447 Add better manual pages CSS
Submitted: 2008-03-20 10:39 UTC Modified: 2009-06-03 15:30 UTC
From: doconnor Assigned: dufuz
Status: Closed Package: pearweb (version CVS)
PHP Version: Irrelevant OS:
Roadmaps: 1.19.0    
Subscription  


 [2008-03-20 10:39 UTC] doconnor (Daniel O'Connor)
Description: ------------ It's hard to grok at the moment

Comments

 [2008-03-20 14:08 UTC] dufuz (Helgi Þormar Þorbjörnsson)
Could you redo the patch with no rgb values ? Is this against manual.css ?
 [2008-03-21 08:17 UTC] dufuz (Helgi Þormar Þorbjörnsson)
the rgb values are still there ... I don't want to mix hex and rgb together like that, go all hex in the patch not rgb
 [2008-03-21 08:49 UTC] dufuz (Helgi Þormar Þorbjörnsson)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.
 [2008-03-21 22:57 UTC] doconnor (Daniel O'Connor)
Here's a new patch which excludes user notes from styling
 [2008-03-22 12:16 UTC] wiesemann (Mark Wiesemann)
Daniel, your screenshots compared the accidently broken old layout with your new layout. The notes inside the manual pages accidently got a style with boxes at the time the user notes system was integrated. Formerly and with the last CVS version of manual.css it looked like this: http://tmp.markwiesemann.eu/pear-manual-notes.png This is also the look with current CVS (at least on my system!?), i.e. with the patch that Helgi applied. Instead, the user notes are styled with the yellow box. Maybe your new "patch" fixes this, but this doesn't look like a real patch. :-(
 [2008-03-22 12:20 UTC] dufuz (Helgi Þormar Þorbjörnsson)
His new file fixes it, I just have to integrate it when this bug triage day is over.
 [2008-03-22 16:43 UTC] dufuz (Helgi Þormar Þorbjörnsson)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.
 [2008-03-22 17:05 UTC] wiesemann (Mark Wiesemann)
Sorry, but this is still ugly: http://tmp.markwiesemann.eu/pear-manual-boxes.png - width of the new yellow box (formerly: no background color, no border) - "shape" of the borders (now solid, formerly dashed on the user notes on the bottom of the page)
 [2008-03-22 17:33 UTC] dufuz (Helgi Þormar Þorbjörnsson)
Well I decide that the user notes should be solid not dashed, dashed was plain ugly. I'll make Daniel look into the yellow box thingy, but I suspect a little margin will be enough, don't you agree ? CVS up and see if this looks any better for you.
 [2008-03-22 17:56 UTC] wiesemann (Mark Wiesemann)
> Well I decide that the user notes should be solid not > dashed, dashed was plain ugly. Actually, IMHO all borders aren't needed there. We could do it simply like php.net does it (no border), e.g.: http://www.php.net/preg_match > I'll make Daniel look into the yellow box thingy, but I > suspect a little margin will be enough, don't you agree ? Current CVS looks better, yes. I've compared IE 7 and FF 2: The red border is only shown by FF, and as red is not really a color that is used anywhere else on the website, I'd say that this note box also doesn't need a border at all.
 [2008-03-22 22:02 UTC] doconnor (Daniel O'Connor)
Border or margin, take your pick and i'll fix
 [2008-03-22 22:22 UTC] doconnor (Daniel O'Connor)
I dropped the borders from notes - no wonder the borders looked horrible, there was a whole bunch of nested tags with the same style. I'm tempted to take a carving knife to some of the generated markup, because it's a bit of tag soup in some places :S IE - http://pear.php.net/manual/en/standards.php#standards.indenting - named anchors all over the place; so underlines make things look ugly
 [2008-03-22 23:06 UTC] doconnor (Daniel O'Connor)
Here. Shiny patch against revision 1.19 of manual.css Should deal with * User notes have no unexpected ugly border * PHP, XML code snippets have no border, gray background * Notes have no border, a little bit of margin
 [2009-04-29 22:15 UTC] cweiske (Christian Weiske)
-Roadmap Versions: 1.18.0 +Roadmap Versions:
 [2009-04-29 22:15 UTC] cweiske (Christian Weiske)
-Roadmap Versions: +Roadmap Versions: 1.19.0
 [2009-06-03 15:30 UTC] doconnor (Daniel O'Connor)
-Status: Assigned +Status: Closed
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.