Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.2.0

Request #13437 Make use of PHP5 language features
Submitted: 2008-03-19 12:46 UTC
From: troehr Assigned: beni
Status: Closed Package: Net_LDAP2 (version 2.0.0RC1)
PHP Version: 5.0.0 OS:
Roadmaps: 2.0.0    
Subscription  


 [2008-03-19 12:46 UTC] troehr (Torsten Roehr)
Description: ------------ As this is a PHP5-only package now it can make use of some of PHP5's new language features. I have created a patch for each file with the following changes: - replace 'var' with 'public'/'protected' - use '__construct()' as constructor - replace 'is_a' with 'inctanceof' - set p/p/p visibility for methods - use 'self::' instead of class name I have run a lint check (php -l) on all files. As I do not have access to a test LDAP server I can not run the unit tests. Best regards, Torsten

Comments

 [2008-03-19 12:51 UTC] beni (Benedikt Hallinger)
Thank you Torsten for your patches! I will review the patches and run the unit tests the next days.
 [2008-03-20 08:36 UTC] beni (Benedikt Hallinger)
Your patches applied very well, i had to make only very little changes concerning the api. Some additions were neccessary changing Net_LDAP2s API a little bit, but it should be downward compatible in nearly all cases - the other cases violate encapsulation/access, so they should be fixed anyway. Again, thanks for your work!