Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 2.0.0a1

Bug #13169 Undefined variables
Submitted: 2008-02-21 10:45 UTC Modified: 2008-02-21 18:16 UTC
From: mapi Assigned: squiz
Status: Closed Package: PHP_CodeSniffer (version CVS)
PHP Version: 5.2.5 OS: any
Roadmaps: 1.1.0    
Subscription  


 [2008-02-21 10:45 UTC] mapi (Manuel Pichler)
Description: ------------ PHPUnit 3.2.15 failed for the Squiz_Tests_Commenting_VariableCommentUnitTest test suite because there are two undefined variables in the class Squiz_Sniffs_Commenting_VariableCommentSniff. The attached patch fixes the test case but I am not sure if I have to initialize $newlineCount with 0 and the test case is wrong or if the initial value 1 is correct.

Comments

 [2008-02-21 18:16 UTC] squiz (Greg Sherwood)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Strangely enough, I couldn't replicate the failing test on 3.2.15, but I did see the problem and have fixed it. To answer your question about $newlineCount, it needs to be 1 if the short comment is empty and 0 otherwise.