Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.26.0

Bug #12830 Javascript error on Google map in IE
Submitted: 2008-01-04 16:56 UTC Modified: 2008-01-05 19:52 UTC
From: kalle Assigned: davidc
Status: Closed Package: pearweb (version 1.17.0)
PHP Version: Irrelevant OS: Windows XP
Roadmaps: 1.17.1    
Subscription  


 [2008-01-04 16:56 UTC] kalle (Kalle Sommer Nielsen)
Description: ------------ When opening the google map to edit your pear profile and then click the 'X' to close the popup then IE issues an javascript error: 'undefined' is null or not an object. Another issue in the same area is that the <a href="#"> cause the map to glide behind the top menu if you're screen res is big (1280x1024+), this can simply be fixed by saying: <a href="javascript:void(0);"> IE Version: 7.0.5370.11 Windows Version: 5.1 [build 2600] Test script: --------------- Simply go to the "Profile" link when logged into pear Expected result: ---------------- No javascript error and everything to run smooth ;)

Comments

 [2008-01-04 17:02 UTC] davidc (David Coallier)
I'll look into this, but using href="javascript:void(0);" is simply wrong since javascript itself is NOT a protocol. Some can argue but there are different and much more elegant ways of fixing this :). I will address this issue and since I have no IE handy, you'll be able to test it. Thanks,
 [2008-01-04 17:09 UTC] wiesemann (Mark Wiesemann)
<a href="#"> is fine, but "return false;" should be added at the end of the onclick attribute to avoid some funny IE behaviours.
 [2008-01-05 06:29 UTC] kalle (Kalle Sommer Nielsen)
Seems like the javascript error when clicking on the X isn't anymore, but now its when you click on your location on the map. Cheers
 [2008-01-05 19:52 UTC] davidc (David Coallier)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.