Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.7

Bug #12415 formSubmit always returns true
Submitted: 2007-11-10 03:32 UTC Modified: 2008-01-24 12:32 UTC
From: unki Assigned: jeichorn
Status: Closed Package: HTML_AJAX (version 0.5.2)
PHP Version: Irrelevant OS: Debian GNU/Linux
Roadmaps: 0.5.3    
Subscription  


 [2007-11-10 03:32 UTC] unki (Andreas Unterkircher)
Description: ------------ Hi, I'm trying to submit an HTML-form via formSubmit. Since I want to wait for the result, I set isAsync to false via the third option parameter of formSubmit(): HTML_AJAX.formSubmit(obj, null, {isAsync: false}); formSubmit() calls makeRequest() - and makeRequest() seems to act correct when isAsync=false and returns the result with the code: return this._decodeResponse(); at line 1809 in HTML_AJAX.js. I verified this with an window.alert() in this place. formSubmit() on the other hand in the lines 518&519 is ignoring the return value and always returns "true" regardless what makeRequest() returns. I guess, there should be a check: if isAsync!=false HTML_AJAX.makeRequest(request); return true; else return HTML_AJAX.makeRequest(request); end

Comments

 [2008-01-20 03:48 UTC] unki (Andreas Unterkircher)
Hi, Fixing this bug seems to be quiet easy. Could you please add this to HTML_AJAX? Currently I always have to overwrite the formSubmit() function with my own. Thanks, Andreas
 [2008-01-24 12:31 UTC] jeichorn (Joshua Eichorn)
Fixed in svn
 [2008-03-28 03:01 UTC] unki (Andreas Unterkircher)
Hello, Is there any schedule when 0.5.3 will be released? Cheers, Andreas