Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.5.2

Bug #12152 coding standard errors plus no unit testing
Submitted: 2007-09-30 11:28 UTC Modified: 2007-09-30 11:35 UTC
From: kguest Assigned: kguest
Status: Closed Package: Validate_PL (version CVS)
PHP Version: 5.1.6 OS: Ubuntu Linux
Roadmaps: (Not assigned)    
Subscription  


 [2007-09-30 11:28 UTC] kguest (Ken Guest)
Description: ------------ $ phpcs --report=summary PL.php PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- /home/kguest/dev/code/pear/pear/Validate/Validate/PL.php 25 13 -------------------------------------------------------------------------------- A TOTAL OF 25 ERROR(S) AND 13 WARNING(S) WERE FOUND IN 1 FILE(S) --------------------------------------------------------------------------------

Comments

 [2007-09-30 11:35 UTC] kguest (Ken Guest)
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. generated some values for the tests against older version of the code so as to ensure no bugs have been introduced after making Coding Standard related changes. using code similar to: require 'Validate/PL.php'; $f = 94332537; $i = 0; $ar = array(); for ($i=0; $i<99999999; $i++){ $t = $f + $i; echo "testing $t"; $r = Validate_PL::bankBranch((string) $t); if (!$r) { $ar[] = $t; echo " NOT VALID"; if (sizeof($ar) == 5) { break; } } echo "\n"; } print_r($ar);