Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.5.0a1

Bug #11683 examples displayed using earthli style are not rendered properly
Submitted: 2007-07-25 01:21 UTC Modified: 2007-08-08 15:59 UTC
From: kguest Assigned: ashnazg
Status: Closed Package: PhpDocumentor (version 1.4.0)
PHP Version: 5.1.6 OS: Ubuntu Linux
Roadmaps: 1.4.1    
Subscription  


 [2007-07-25 01:21 UTC] kguest (Ken Guest)
Description: ------------ examples displayed using earthli style are not rendered properly; the line-height values in the .css are "0.5em" rather than equal to or greater than "1.0em" and are causing the lines of code in the examples to be 'layered' on top of each other.

Comments

 [2007-07-30 19:23 UTC] jeichorn (Joshua Eichorn)
This looks like a pretty low risk change, but lets at least test things in firefox 2 and ie6/ie7 I can help with IE if needed
 [2007-08-04 12:22 UTC] ashnazg (Chuck Burgess)
I ran the current CVS code against itself, thinking I'd see this bug evidenced by the three sampleX.php files in the tutorial. But, using both HTML:frames:earthli and HTML:frames:DOM/earthli, I don't see any issue with lines overlapping each other when I view these files via the Tutorial menu: -> Tutorials/Manuals ---> Package-level -----> TutorialphpDocumentor Guide to Creating Fantastic Documentation -------> TutorialphpDocumentor Quickstart ---------> TutorialSource code for sample1.php Any chance you can upload an example file I can run against that demonstrates the line overlapping?
 [2007-08-08 04:02 UTC] kguest (Ken Guest)
this problem also exhibits with the sample files - only if you link them as examples (ie with @example /usr/share/php/docs/PhpDocumentor/tutorials/phpDocumentor/examples/sample1.php in a class docblock) , generate the docs and click on the example link that you created with the @example tag. The issue does not exhibit if you click a 'filesource' listing; ie follow links through to variable or function declarations).
 [2007-08-08 08:40 UTC] ashnazg (Chuck Burgess)
Ah, that helped... I can duplicate it now, so I'll have a working testcase. It doesn't not appear to be a problem with the DOM/earthli, like I thought it might... just the regular earthli like you reported. Thanks Ken!
 [2007-08-08 08:41 UTC] ashnazg (Chuck Burgess)
Ran my test file against all the HTML converters... HTML:frames:earthli is the only one affected.
 [2007-08-08 08:48 UTC] ashnazg (Chuck Burgess)
Ken's patch tests good for me... it clears up the line squashing when I view it in FF2 and IE6. Will install IE7 to test it...
 [2007-08-08 15:57 UTC] ashnazg (Chuck Burgess)
Looks good in IE7 also.
 [2007-08-08 15:59 UTC] ashnazg (Chuck Burgess)
Committed to CVS.