Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.4.4

Request #11523 Testing_Selenium.doCommand: private vs protected/public
Submitted: 2007-07-05 03:10 UTC Modified: 2007-10-15 11:55 UTC
From: geirhelge Assigned: shin
Status: Closed Package: Testing_Selenium (version 0.3.1)
PHP Version: 5.2.3 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2007-07-05 03:10 UTC] geirhelge (Geir Helge Tjøstolvsen-Schmidt)
Description: ------------ Is there a reason why the doCommand method is set to private? It would be very nice to have it protected so that we can extend the class in order to add commands that are available from the Selenium RC but not yet in this client. The command I want to use now is waitForElementPresent, but to do this I will have to use this code for each page that I load (making the test script very long and less readable): for ($second = 0; ; $second++) { if ($second >= 60) $this->fail("timeout"); try { if ($this->selenium->isElementPresent("link:Kategorier")) break; } catch (Exception $e) {} sleep(1); } } This is just an example and I guess there might be similar cases like this as we continue to create more tests

Comments

 [2007-07-07 08:58 UTC] shin (Shin Ohno)
hello, Geir. I thought nobody would like to extend doCommand method, but it sounds like there is a demand. Please wait for the next release, 0.3.2. I will fix this in next version. Thanx for the request.
 [2007-10-15 11:55 UTC] shin (Shin Ohno)
Sorry, I forgot to close this request. doCommand is now protected method.